Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.21] Fix rancher traefik upgrade suggestion #4326

Merged

Conversation

brandond
Copy link
Member

@brandond brandond commented Oct 26, 2021

Proposed Changes

Add dashboard annotation to the Traefik helm chart to prevent Rancher from suggesting upgrades to it.

The 'hidden' annotation only works on charts in the repo, not ones installed to the cluster. This makes it show as 'Managed' in the UI.

Types of Changes

bugfix

Verification

Import K3s cluster into Rancher or install Rancher on K3s. Note that it no longer suggests upgrading the packaged Traefik.

Linked Issues

User-Facing Change

Rancher will no longer suggest upgrading the Traefik chart packaged with K3s.

Further Comments

@brandond brandond requested a review from a team as a code owner October 26, 2021 00:32
@brandond brandond marked this pull request as draft October 26, 2021 02:09
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
@brandond brandond force-pushed the fix_rancher_traefik_upgrade_release-1.21 branch from 5d9be56 to ba8c728 Compare October 27, 2021 05:05
@brandond brandond marked this pull request as ready for review October 27, 2021 05:07
@brandond brandond merged commit c9d4543 into k3s-io:release-1.21 Nov 11, 2021
@brandond brandond deleted the fix_rancher_traefik_upgrade_release-1.21 branch June 6, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants