Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace gzip with pigz for faster builds #4411

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

dereknola
Copy link
Member

@dereknola dereknola commented Nov 5, 2021

Signed-off-by: dereknola derek.nola@suse.com

Proposed Changes

Replace gzip with pigz

Tests:

  • 6 core, 12 thread machine
  • Ubuntu 20.04

Average time of 3 runs of make with gzip: 2m 34s
Average time of 3 runs of make with pigz: 2m 15s

Types of Changes

Enhancement

Verification

make passes

Linked Issues

#4410

User-Facing Change


Further Comments

Signed-off-by: dereknola <derek.nola@suse.com>
@dereknola dereknola requested a review from a team as a code owner November 5, 2021 21:01
Copy link
Contributor

@briandowns briandowns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Is this pigz a bit more consistent and deterministic than gzip?

@dereknola
Copy link
Member Author

I'm not sure about deterministic, I believe it uses the same compression algorithm as gzip, but in parallel on 128KB chunks, with 32K block from the previous chunk as a dictionary to maintain compression efficiency. You can read more about it here https://zlib.net/pigz/pigz.pdf

@dereknola dereknola merged commit 8915e4c into k3s-io:master Nov 8, 2021
@dereknola dereknola deleted the pigz_build branch November 16, 2021 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants