[1.22] Wrap containerd.New #5362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luthermonson
force-pushed
the
fix-containerd-npipe-122
branch
2 times, most recently
from
e299662 to
c459950
Compare
…er npipe connector Signed-off-by: Luther Monson <luther.monson@gmail.com>
luthermonson
force-pushed
the
fix-containerd-npipe-122
branch
from
c459950 to
4a97a7c
Compare
Codecov Report
@@ Coverage Diff @@
## release-1.22 #5362 +/- ##
===============================================
- Coverage 9.54% 9.54% -0.01%
===============================================
Files 134 134
Lines 9446 9450 +4
===============================================
Hits 902 902
- Misses 8353 8357 +4
Partials 191 191
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
brandond
approved these changes
Mar 30, 2022
briandowns
approved these changes
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
problem: While setting up containerd we make a client and the name of the npipe for windows is
npipe://./pipe/containerd-containerdbut at some point between windows server patches and the winio dialer we got to a place where it's expecting\\.\pipe\containerd-containerdand the npipe:// needed to be dropped. This was fixed CriConnection as the address was wrapped withutils.GetAddressAndDialerbut the second call to containerd.New for a client didn't have this.Fix: wrap the containerd.New call with a func that parses the address properly and pass that down
rancher/rke2#2161
rancher/windows#72