Improve support for rotating the default self-signed certs #7032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandond
force-pushed
the
more_cert_scripts
branch
4 times, most recently
from
092edb6
to
a8757e1
Compare
brandond
changed the title
brandond
force-pushed
the
more_cert_scripts
branch
3 times, most recently
from
0119333
to
74804b6
Compare
dereknola
approved these changes
Mar 8, 2023
brandond
force-pushed
the
more_cert_scripts
branch
from
74804b6
to
432b40a
Compare
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
We need to send the full chain in order for cross-signing to work properly during switchover to a new root. Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
force-pushed
the
more_cert_scripts
branch
from
432b40a
to
82e2b80
Compare
briandowns
approved these changes
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
While writing docs for self-signed cert CA rotation, I realized it really needs its own script. There's also a tweak to the client and server certs and rotate-ca validation checks that we can make to avoid having to restart all the pods after rotating the default self-signed CA certs.
Types of Changes
enhancement
Verification
See docs
Testing
Linked Issues
User-Facing Change
Further Comments