Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Use logrus to report the error instead of fmt to avoid an rke2 windows bug.
This fixes: rancher/rke2#4693
To report stuff on Windows Event Logger, we are using a logrus hook, i.e. any log created by logrus, gets printed in the Event Tracing for Windows (EWT) (some sort of journalctl). However, anything else is dropped, e.g. fmt messages.
https://github.com/rancher/wins/blob/main/pkg/logs/etw.go#L125-L132
Types of Changes
Bugfix
Verification
Try breaking something in containerd/k3s and check that it gets reported correctly in journalctl
Testing
The bug is in rke2
Linked Issues
rancher/rke2#4693
#8251
User-Facing Change
Further Comments