Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include the interface name in the error message #8346

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

manuelbuil
Copy link
Contributor

Proposed Changes

Add the name of the interface to the error messages to help debugging

Types of Changes

Bugfix

Verification

Use k3s rootless as querying the interface will fail

Testing

Linked Issues

#8345

User-Facing Change


Further Comments

@manuelbuil manuelbuil requested a review from a team as a code owner September 13, 2023 14:00
Copy link
Contributor

@brandond brandond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

: is usually used to delimit separate messages in the error stack, we should avoid using it as part of the message.

pkg/agent/config/config.go Outdated Show resolved Hide resolved
pkg/util/net.go Outdated Show resolved Hide resolved
Signed-off-by: Manuel Buil <mbuil@suse.com>
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Patch coverage: 43.75% and project coverage change: +2.26% 🎉

Comparison is base (6330a5b) 47.43% compared to head (8c197bd) 49.70%.
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8346      +/-   ##
==========================================
+ Coverage   47.43%   49.70%   +2.26%     
==========================================
  Files         143      143              
  Lines       14741    14746       +5     
==========================================
+ Hits         6992     7329     +337     
+ Misses       6643     6249     -394     
- Partials     1106     1168      +62     
Flag Coverage Δ
e2etests 48.97% <50.00%> (?)
inttests 41.04% <0.00%> (-3.72%) ⬇️
unittests 19.83% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/agent/config/config.go 50.71% <0.00%> (+1.97%) ⬆️
pkg/agent/containerd/containerd.go 20.39% <0.00%> (+0.49%) ⬆️
pkg/cli/agent/agent.go 26.22% <40.00%> (+26.22%) ⬆️
pkg/cli/server/server.go 55.90% <40.00%> (-2.44%) ⬇️
pkg/util/net.go 56.69% <75.00%> (+9.58%) ⬆️

... and 44 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants