Don't ignore assets in home dir if system assets exist #8458
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Prefer user assets over system assets, if both exist
Types of Changes
bugfix
Verification
On old release
k3s check-config
as unprivileged user; note that assets are extracted out to$HOME/.rancher/k3s/data
and checkedk3s check-config
as root; note that assets are extracted out to/var/lib/rancher/k3s/data
and checkedk3s check-config
as unprivileged user again; note that this time the assets in/var/lib/rancher/k3s/data
are checked, instead of the user assets.On new release
Perform above steps, but in step 4, note that the assets in the home directory are still checked, even if system-level assets exist.
Testing
Linked Issues
k3s check-config
does not respect rootless mode #8403User-Facing Change
Further Comments