Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.28] System agent push tags fix #8568

Merged
merged 2 commits into from
Oct 6, 2023

Conversation

johnatasr
Copy link
Contributor

@johnatasr johnatasr commented Oct 6, 2023

Proposed Changes

  • change cURL to push tags with a new created token
  • add in drone step the new token as a secret

Types of Changes

  • CI

Verification

Testing

Linked Issues

https://github.com/rancherlabs/eio/issues/1643

User-Facing Change


Further Comments

Signed-off-by: Johnatas <johnatasr@hotmail.com>
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (a5485a5) 47.23% compared to head (1f7c692) 51.47%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8568      +/-   ##
==========================================
+ Coverage   47.23%   51.47%   +4.24%     
==========================================
  Files         143      143              
  Lines       14806    14806              
==========================================
+ Hits         6993     7621     +628     
+ Misses       6696     5975     -721     
- Partials     1117     1210      +93     
Flag Coverage Δ
e2etests 48.74% <ø> (?)
inttests 44.40% <ø> (-0.17%) ⬇️
unittests 19.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 44 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Johnatas <johnatasr@hotmail.com>
@johnatasr johnatasr marked this pull request as ready for review October 6, 2023 17:47
@johnatasr johnatasr requested a review from a team as a code owner October 6, 2023 17:47
@johnatasr johnatasr changed the title System agent push tags fix [v1.28] System agent push tags fix Oct 6, 2023
@johnatasr johnatasr merged commit ba750e2 into k3s-io:master Oct 6, 2023
15 checks passed
seanyen pushed a commit to seanyen/k3s that referenced this pull request Oct 6, 2023
* change script and drone

Signed-off-by: Johnatas <johnatasr@hotmail.com>

* adjust secret

Signed-off-by: Johnatas <johnatasr@hotmail.com>

---------

Signed-off-by: Johnatas <johnatasr@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants