Tweaked order of ingress IPs in ServiceLB #8711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, ingress IPs were only string-sorted when returned Sorted by IP family and string-sorted in each family as part of filterByIPFamily method Signed-off-by: Jason Costello <jason@jsnc.tl>
brandond
requested changes
Oct 24, 2023
Co-authored-by: Brad Davidson <brad@oatmail.org> Signed-off-by: Jason Costello <jason@hazy.com>
|
CI is failing but see that in other PRs so guess this is a known issue? Holding off merge until code freeze is up too? |
|
No, it looks like your formatting is off. Editors will usually handle this for you, if yours does not you may need to use the gofmt CLI tool to fix it.
|
Signed-off-by: Jason Costello <jason@jsnc.tl>
jsnctl
force-pushed
the
servicelb-ingress-ips-better-sorting
branch
from
01a08ea
to
fccc6f3
Compare
|
Anything further to pick up on this PR with the formatting fixed @brandond? |
|
no, we're just waiting on release activity before merging any PRs. Thanks for your patience! |
brandond
approved these changes
Nov 9, 2023
dereknola
approved these changes
Nov 15, 2023
|
s390x is flaking; merging |
brandond
added a commit
to brandond/k3s
that referenced
this pull request
Nov 16, 2023
* Tweaked order of ingress IPs in ServiceLB
Previously, ingress IPs were only string-sorted when returned
Sorted by IP family and string-sorted in each family as part of
filterByIPFamily method
* Update pkg/cloudprovider/servicelb.go
* Formatting
Signed-off-by: Jason Costello <jason@hazy.com>
Co-authored-by: Brad Davidson <brad@oatmail.org>
(cherry picked from commit 07ee854)
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
added a commit
to brandond/k3s
that referenced
this pull request
Nov 16, 2023
* Tweaked order of ingress IPs in ServiceLB
Previously, ingress IPs were only string-sorted when returned
Sorted by IP family and string-sorted in each family as part of
filterByIPFamily method
* Update pkg/cloudprovider/servicelb.go
* Formatting
Signed-off-by: Jason Costello <jason@hazy.com>
Co-authored-by: Brad Davidson <brad@oatmail.org>
(cherry picked from commit 07ee854)
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
added a commit
to brandond/k3s
that referenced
this pull request
Nov 16, 2023
* Tweaked order of ingress IPs in ServiceLB
Previously, ingress IPs were only string-sorted when returned
Sorted by IP family and string-sorted in each family as part of
filterByIPFamily method
* Update pkg/cloudprovider/servicelb.go
* Formatting
Signed-off-by: Jason Costello <jason@hazy.com>
Co-authored-by: Brad Davidson <brad@oatmail.org>
(cherry picked from commit 07ee854)
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
added a commit
that referenced
this pull request
Nov 16, 2023
* Tweaked order of ingress IPs in ServiceLB
Previously, ingress IPs were only string-sorted when returned
Sorted by IP family and string-sorted in each family as part of
filterByIPFamily method
* Update pkg/cloudprovider/servicelb.go
* Formatting
Signed-off-by: Jason Costello <jason@hazy.com>
Co-authored-by: Brad Davidson <brad@oatmail.org>
(cherry picked from commit 07ee854)
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
added a commit
that referenced
this pull request
Nov 16, 2023
* Tweaked order of ingress IPs in ServiceLB
Previously, ingress IPs were only string-sorted when returned
Sorted by IP family and string-sorted in each family as part of
filterByIPFamily method
* Update pkg/cloudprovider/servicelb.go
* Formatting
Signed-off-by: Jason Costello <jason@hazy.com>
Co-authored-by: Brad Davidson <brad@oatmail.org>
(cherry picked from commit 07ee854)
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
added a commit
that referenced
this pull request
Nov 16, 2023
* Tweaked order of ingress IPs in ServiceLB
Previously, ingress IPs were only string-sorted when returned
Sorted by IP family and string-sorted in each family as part of
filterByIPFamily method
* Update pkg/cloudprovider/servicelb.go
* Formatting
Signed-off-by: Jason Costello <jason@hazy.com>
Co-authored-by: Brad Davidson <brad@oatmail.org>
(cherry picked from commit 07ee854)
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
This was referenced Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, ingress IPs were only string-sorted when returned
Sorted by IP family and string-sorted in each family as part of filterByIPFamily method
Proposed Changes
Addresses #8704 with adjustment and use of
filterByIPFamilyas part ofservicelb.getStatusTypes of Changes
Bugfix
Verification
Added new unit test to
servicelb_test.goTesting
See above
Linked Issues
User-Facing Change
Further Comments
Hopefully my first PR of many. Great project