Fix s3 snapshot restore #8729
Merged
Fix s3 snapshot restore #8729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dereknola
approved these changes
Oct 27, 2023
vitorsavian
approved these changes
Oct 27, 2023
briandowns
approved these changes
Oct 27, 2023
johnatasr
approved these changes
Oct 27, 2023
These fields are only necessary when saving snapshots to S3, and will block restoration if attempted Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
force-pushed
the
fix-s3-snapshot-restore
branch
from
95b0681 to
c0d00b9
Compare
|
We're currently processing your upload. This comment will be updated when the results are available. |
This was referenced Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Don't try to read token hash and cluster id during cluster-reset
These fields are only necessary when saving snapshots to S3, and will block restoration if attempted
Types of Changes
bugfix
Verification
See linked issue
Testing
Linked Issues
User-Facing Change
Further Comments