Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with snapshot metadata configmap #8835

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

brandond
Copy link
Member

Proposed Changes

Omit snapshot list configmap entries for snapshots without extra metadata; reduce log level of warnings about missing s3 metadata files.

Types of Changes

bugfix

Verification

See linked issue

Testing

Linked Issues

User-Facing Change

Omit snapshot list configmap entries for snapshots without extra metadata

Further Comments

Omit snapshot list configmap entries for snapshots without extra metadata; reduce log level of warnings about missing s3 metadata files.

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
@brandond brandond requested a review from a team as a code owner November 14, 2023 23:14
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (f5920d7) 42.19% compared to head (f01765b) 49.99%.
Report is 6 commits behind head on master.

Files Patch % Lines
pkg/etcd/s3.go 0.00% 10 Missing ⚠️
pkg/etcd/snapshot_controller.go 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8835      +/-   ##
==========================================
+ Coverage   42.19%   49.99%   +7.80%     
==========================================
  Files         150      150              
  Lines       15790    15798       +8     
==========================================
+ Hits         6662     7898    +1236     
+ Misses       8078     6644    -1434     
- Partials     1050     1256     +206     
Flag Coverage Δ
e2etests 47.08% <0.00%> (?)
inttests 44.12% <25.00%> (+5.15%) ⬆️
unittests 18.18% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants