Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to install K3s PR Artifact from GitHub #9185

Merged
merged 4 commits into from
Feb 7, 2024

Conversation

dereknola
Copy link
Member

@dereknola dereknola commented Jan 9, 2024

Proposed Changes

Context: With the removal of AWS S3 uploads for K3s PRs, we need another way for QA to easily validate open PR builds of K3s.

  • Adds the ability for the install script to pull the K3s executable built during GitHub CI (specifically the integration test build step found here)

Note: Only this PR has the changes necessary to support "installing from PR". This is due to the sha256sum for the k3s binary being added as a GitHub artifact in this PR. So this is a "PRs newer than this one" feature, not "works on all PRs going back forever" feature.

Types of Changes

Install script feature

Verification

Testing

Covered by existing install tests

export GITHUB_TOKEN=<XXX>
cd tests/install/ubuntu-focal/
INSTALL_K3S_PR=9185 vagrant up

Linked Issues

User-Facing Change

Adds `INSTALL_K3S_PR` option to install a build of K3s from any open PR with CI approval

Further Comments

@dereknola dereknola requested a review from a team as a code owner January 9, 2024 18:50
Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d8907ce) 40.53% compared to head (30ec9a9) 40.52%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9185      +/-   ##
==========================================
- Coverage   40.53%   40.52%   -0.01%     
==========================================
  Files         154      154              
  Lines       16555    16555              
==========================================
- Hits         6710     6709       -1     
- Misses       8697     8698       +1     
  Partials     1148     1148              
Flag Coverage Δ
inttests 37.68% <ø> (-0.01%) ⬇️
unittests 14.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants