Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition from deprecated pointer library to ptr #9801

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

dereknola
Copy link
Member

@dereknola dereknola commented Mar 27, 2024

Proposed Changes

Types of Changes

Verification

CI Green, K3s makes

Testing

Linked Issues

#9819

User-Facing Change


Further Comments

Signed-off-by: Derek Nola <derek.nola@suse.com>
@dereknola dereknola requested a review from a team as a code owner March 27, 2024 16:45
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 26.66667% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 28.61%. Comparing base (b5d0d4e) to head (025949a).
Report is 1 commits behind head on master.

Files Patch % Lines
pkg/cli/secretsencrypt/secrets_encrypt.go 0.00% 6 Missing ⚠️
pkg/server/secrets-encrypt.go 0.00% 2 Missing ⚠️
pkg/cli/token/token.go 0.00% 1 Missing ⚠️
pkg/cloudprovider/servicelb.go 0.00% 1 Missing ⚠️
pkg/spegel/spegel.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #9801       +/-   ##
===========================================
- Coverage   52.88%   28.61%   -24.28%     
===========================================
  Files         155      155               
  Lines       13597    13597               
===========================================
- Hits         7191     3891     -3300     
- Misses       5044     8924     +3880     
+ Partials     1362      782      -580     
Flag Coverage Δ
e2etests 8.57% <6.66%> (-40.74%) ⬇️
inttests 21.31% <6.66%> (-18.14%) ⬇️
unittests 16.40% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dereknola dereknola merged commit 14f54d0 into k3s-io:master Mar 28, 2024
26 checks passed
@dereknola dereknola deleted the pointer_util branch March 28, 2024 17:07
dereknola added a commit to dereknola/k3s that referenced this pull request Mar 28, 2024
Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola added a commit to dereknola/k3s that referenced this pull request Mar 28, 2024
Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola added a commit to dereknola/k3s that referenced this pull request Mar 28, 2024
Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola added a commit that referenced this pull request Mar 31, 2024
Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola added a commit that referenced this pull request Mar 31, 2024
Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola added a commit that referenced this pull request Mar 31, 2024
Signed-off-by: Derek Nola <derek.nola@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants