Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Local path provisioner to read helper logs #9835

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

zc-devs
Copy link
Contributor

@zc-devs zc-devs commented Mar 29, 2024

Proposed Changes

Added permissions for Local path provisioner to read helper Pod's logs

Types of Changes

Bugfix

Verification

Steps from #9834
Should not be local-path-provisioner-service-account cannot get resource "pods/log" error, but logs from helper Pod.

Testing

Perhaps, no

Linked Issues

User-Facing Change

Further Comments

No

@zc-devs zc-devs requested a review from a team as a code owner March 29, 2024 23:08
@zc-devs zc-devs changed the title Allow LPP to read helper logs Allow Local path provisioner to read helper logs Mar 29, 2024
Copy link
Member

@brandond brandond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

You also need to run make download generate (or run ./scripts/download and then go generate) to update the generated bindata that embeds these files into the binary.

Copy link
Member

@brandond brandond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the zz_generated_bindata.go should have changed; I'm not sure where the unrelated whitespace changes came from. Can you remove the other files from this PR?

brandond
brandond previously approved these changes Apr 2, 2024
@brandond
Copy link
Member

brandond commented Apr 2, 2024

Last thing - please sign-off your commits for DCO!

dereknola
dereknola previously approved these changes Apr 3, 2024
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.18%. Comparing base (3f906be) to head (e2e4275).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9835      +/-   ##
==========================================
- Coverage   47.81%   40.18%   -7.63%     
==========================================
  Files         158      155       -3     
  Lines       14017    13965      -52     
==========================================
- Hits         6702     5612    -1090     
- Misses       6068     7208    +1140     
+ Partials     1247     1145     -102     
Flag Coverage Δ
e2etests 35.53% <ø> (-9.47%) ⬇️
inttests 37.04% <ø> (+29.75%) ⬆️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Thomas Anderson <127358482+zc-devs@users.noreply.github.com>
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
@brandond
Copy link
Member

Rebased

@brandond brandond merged commit c59820a into k3s-io:master Apr 11, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants