-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Local path provisioner to read helper logs #9835
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
You also need to run make download generate
(or run ./scripts/download
and then go generate
) to update the generated bindata that embeds these files into the binary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only the zz_generated_bindata.go
should have changed; I'm not sure where the unrelated whitespace changes came from. Can you remove the other files from this PR?
Last thing - please sign-off your commits for DCO! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9835 +/- ##
==========================================
- Coverage 47.81% 40.18% -7.63%
==========================================
Files 158 155 -3
Lines 14017 13965 -52
==========================================
- Hits 6702 5612 -1090
- Misses 6068 7208 +1140
+ Partials 1247 1145 -102
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Thomas Anderson <127358482+zc-devs@users.noreply.github.com> Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Rebased |
Proposed Changes
Added permissions for Local path provisioner to read helper Pod's logs
Types of Changes
Bugfix
Verification
Steps from #9834
Should not be
local-path-provisioner-service-account cannot get resource "pods/log"
error, but logs from helper Pod.Testing
Perhaps, no
Linked Issues
User-Facing Change
Further Comments
No