Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually fix agent certificate rotation #9902

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

brandond
Copy link
Member

@brandond brandond commented Apr 9, 2024

Proposed Changes

Actually fix agent certificate rotation

Got closer with #9772 but it's still broken :(

Types of Changes

bugfix

Verification

See linked issue

Testing

Linked Issues

User-Facing Change

Further Comments

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
@brandond brandond requested a review from a team as a code owner April 9, 2024 22:58
@brandond
Copy link
Member Author

brandond commented Apr 9, 2024

root@k3s-server-1:~# k3s certificate rotate
INFO[0000] Server detected, rotating agent and server certificates
INFO[0000] Rotating dynamic listener certificate
INFO[0000] Rotating certificates for kubelet
INFO[0000] Rotating certificates for api-server
INFO[0000] Rotating certificates for admin
INFO[0000] Rotating certificates for cloud-controller
INFO[0000] Rotating certificates for controller-manager
INFO[0000] Rotating certificates for etcd
INFO[0000] Rotating certificates for scheduler
INFO[0000] Rotating certificates for supervisor
INFO[0000] Rotating certificates for k3s-controller
INFO[0000] Rotating certificates for auth-proxy
INFO[0000] Rotating certificates for kube-proxy
INFO[0000] Successfully backed up certificates to /var/lib/rancher/k3s/server/tls-1712703646, please restart k3s server or agent to rotate certificates
root@k3s-agent-1:~# k3s certificate rotate
INFO[0000] Agent detected, rotating agent certificates
INFO[0000] Rotating certificates for kube-proxy
INFO[0000] Rotating certificates for kubelet
INFO[0000] Rotating certificates for k3s-controller
INFO[0000] Successfully backed up certificates to /var/lib/rancher/k3s/agent/tls-1712703619, please restart k3s server or agent to rotate certificates

Copy link

codecov bot commented Apr 9, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 43.10%. Comparing base (08f1022) to head (465d0ea).

Files Patch % Lines
pkg/cli/cert/cert.go 50.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9902      +/-   ##
==========================================
- Coverage   49.60%   43.10%   -6.50%     
==========================================
  Files         158      158              
  Lines       14013    14017       +4     
==========================================
- Hits         6951     6042     -909     
- Misses       5758     6835    +1077     
+ Partials     1304     1140     -164     
Flag Coverage Δ
e2etests 35.97% <0.00%> (-10.14%) ⬇️
inttests 37.07% <50.00%> (+0.06%) ⬆️
unittests 16.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brandond brandond merged commit 4cc73b1 into k3s-io:master Apr 10, 2024
27 checks passed
@brandond brandond deleted the fix-agent-rotate branch June 6, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants