-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for TLS skip verification #306
Conversation
Signed-off-by: Antonio Huete Jimenez <tuxillo@quantumachine.net>
This is how I tested it: No skip:
Skip:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! One nit, LGTM otherwise.
main.go
Outdated
@@ -56,6 +56,12 @@ func main() { | |||
Usage: "Key file for etcd connection", | |||
Destination: &config.ServerTLSConfig.KeyFile, | |||
}, | |||
&cli.BoolFlag{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: can you move this up, directly below the Destination: &config.BackendTLSConfig.CertFile
flag? We could probably move the Destination: &config.BackendTLSConfig.KeyFile
flag up as well, just to keep all the backend flags together.
Signed-off-by: Antonio Huete Jimenez <tuxillo@quantumachine.net>
As mentioned here: k3s-io/k3s#1093 , it is not possible to skip TLS verification. This patch adds support for skipping it. Not sure if it's the correct approach tho :)