fix: only log slow sql query parameters if trace logging is enabled #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mezgerj
force-pushed
the
kine-305-no-log-slowsql-query-params
branch
from
2421372
to
4a4470f
Compare
Signed-off-by: john.mezger <john.mezger@corelight.com>
mezgerj
force-pushed
the
kine-305-no-log-slowsql-query-params
branch
from
4a4470f
to
d9a22e7
Compare
brandond
approved these changes
Jul 1, 2024
|
lgtm, thanks! |
|
@brandond thanks for the review. What is the process to get this merged? |
vitorsavian
approved these changes
Jul 1, 2024
|
hey @mezgerj, the process of merging is that any PR need two approvals, after the two approvals one of the devs can go and merge. I'll merge your PR, tks for the contribution!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corrects #305 by only dumping the sql query parameters in the slow sql log if the log level is set to trace.