Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor driver selection to allow registering new drivers #325

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Refactor driver selection to allow registering new drivers #325

merged 1 commit into from
Sep 26, 2024

Conversation

sambhav
Copy link
Contributor

@sambhav sambhav commented Sep 25, 2024 •
edited
Loading

This PR refactors the driver code to allow users to register their own drivers if they wish to.

It also consolidates the I/O that is expected from each driver constructor to a consistent interface.

Fixes #76 as well

@sambhav sambhav requested a review from a team as a code owner September 25, 2024 18:18
brandond
brandond requested changes Sep 25, 2024
View reviewed changes
pkg/drivers/registry.go Outdated Show resolved Hide resolved
brandond
brandond requested changes Sep 25, 2024
View reviewed changes
Copy link
Member

@brandond brandond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another nit

pkg/drivers/registry.go Outdated Show resolved Hide resolved
brandond
brandond requested changes Sep 25, 2024
View reviewed changes
pkg/drivers/registry.go Outdated Show resolved Hide resolved
@brandond
Copy link
Member

Looks like it's still not formatted properly:

#12 1.968 pkg/drivers/generic/generic.go:28: File is not `gofmt`-ed with `-s` (gofmt)

@sambhav
Copy link
Contributor Author

sambhav commented Sep 25, 2024

Should work now, rebased and squashed all the fixes.

@sambhav sambhav requested a review from brandond September 25, 2024 19:54
@sambhav
Copy link
Contributor Author

sambhav commented Sep 25, 2024

Hmm

msg="building kine: no default driver found"

@sambhav sambhav force-pushed the refactor-generic branch 6 times, most recently from 83fc148 to 5016d49 Compare September 25, 2024 20:12
@sambhav
Refactor driver selection to allow registering new drivers
5594b15 
Signed-off-by: Sambhav Kothari <skothari44@bloomberg.net>
@sambhav
Copy link
Contributor Author

sambhav commented Sep 26, 2024 •
edited
Loading

@brandond ok to merge this? Would you also be open to cutting a release?

@brandond brandond merged commit 133503d into k3s-io:master Sep 26, 2024
3 checks passed
@sambhav sambhav deleted the refactor-generic branch September 27, 2024 01:55
brandond added a commit to brandond/k3s that referenced this pull request Oct 2, 2024
@brandond
Fix sqlite endpoint when migrating from sqlite to etcd
9352f55 
Support for 'sqlite' as the endpoint was removed in
k3s-io/kine#320 and the constant removed in
k3s-io/kine#325

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond added a commit to k3s-io/k3s that referenced this pull request Oct 3, 2024
@brandond
Fix sqlite endpoint when migrating from sqlite to etcd
0942e6a 
Support for 'sqlite' as the endpoint was removed in
k3s-io/kine#320 and the constant removed in
k3s-io/kine#325

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond added a commit to brandond/rke2 that referenced this pull request Oct 4, 2024
@brandond
Sync kine for changes from k3s-io/kine#325
045680f 
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond added a commit to brandond/k3s that referenced this pull request Oct 9, 2024
@brandond
Fix sqlite endpoint when migrating from sqlite to etcd
95a250f 
Support for 'sqlite' as the endpoint was removed in
k3s-io/kine#320 and the constant removed in
k3s-io/kine#325

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
(cherry picked from commit 0942e6a)
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond added a commit to brandond/k3s that referenced this pull request Oct 10, 2024
@brandond
Fix sqlite endpoint when migrating from sqlite to etcd
692a0f5 
Support for 'sqlite' as the endpoint was removed in
k3s-io/kine#320 and the constant removed in
k3s-io/kine#325

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
(cherry picked from commit 0942e6a)
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond added a commit to brandond/k3s that referenced this pull request Oct 10, 2024
@brandond
Fix sqlite endpoint when migrating from sqlite to etcd
60231e4 
Support for 'sqlite' as the endpoint was removed in
k3s-io/kine#320 and the constant removed in
k3s-io/kine#325

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
(cherry picked from commit 0942e6a)
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond added a commit to brandond/k3s that referenced this pull request Oct 10, 2024
@brandond
Fix sqlite endpoint when migrating from sqlite to etcd
90338d9 
Support for 'sqlite' as the endpoint was removed in
k3s-io/kine#320 and the constant removed in
k3s-io/kine#325

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
(cherry picked from commit 0942e6a)
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond added a commit to k3s-io/k3s that referenced this pull request Oct 10, 2024
@brandond
Fix sqlite endpoint when migrating from sqlite to etcd
e27aa13 
Support for 'sqlite' as the endpoint was removed in
k3s-io/kine#320 and the constant removed in
k3s-io/kine#325

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
(cherry picked from commit 0942e6a)
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond added a commit to k3s-io/k3s that referenced this pull request Oct 10, 2024
@brandond
Fix sqlite endpoint when migrating from sqlite to etcd
cc4e044 
Support for 'sqlite' as the endpoint was removed in
k3s-io/kine#320 and the constant removed in
k3s-io/kine#325

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
(cherry picked from commit 0942e6a)
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond added a commit to k3s-io/k3s that referenced this pull request Oct 10, 2024
@brandond
Fix sqlite endpoint when migrating from sqlite to etcd
4d0a613 
Support for 'sqlite' as the endpoint was removed in
k3s-io/kine#320 and the constant removed in
k3s-io/kine#325

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
(cherry picked from commit 0942e6a)
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond added a commit to k3s-io/k3s that referenced this pull request Oct 10, 2024
@brandond
Fix sqlite endpoint when migrating from sqlite to etcd
67138dc 
Support for 'sqlite' as the endpoint was removed in
k3s-io/kine#320 and the constant removed in
k3s-io/kine#325

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
(cherry picked from commit 0942e6a)
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond added a commit to brandond/rke2 that referenced this pull request Oct 11, 2024
@brandond
Sync kine changes from k3s-io/kine#325
dfc5d14 
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond added a commit to brandond/rke2 that referenced this pull request Oct 11, 2024
@brandond
Sync kine changes from k3s-io/kine#325
8fad5d2 
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond added a commit to brandond/rke2 that referenced this pull request Oct 11, 2024
@brandond
Sync kine changes from k3s-io/kine#325
fd28c85 
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond added a commit to brandond/rke2 that referenced this pull request Oct 11, 2024
@brandond
Sync kine changes from k3s-io/kine#325
208775f 
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond added a commit to brandond/rke2 that referenced this pull request Oct 11, 2024
@brandond
Sync kine changes from k3s-io/kine#325
652ad53 
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond added a commit to brandond/rke2 that referenced this pull request Oct 11, 2024
@brandond
Sync kine changes from k3s-io/kine#325
11a8f90 
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond added a commit to brandond/rke2 that referenced this pull request Oct 11, 2024
@brandond
Sync kine changes from k3s-io/kine#325
ca9fffa 
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond added a commit to brandond/rke2 that referenced this pull request Oct 11, 2024
@brandond
Sync kine changes from k3s-io/kine#325
366133e 
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond added a commit to brandond/rke2 that referenced this pull request Oct 11, 2024
@brandond
Sync kine changes from k3s-io/kine#325
9a2c78a 
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond added a commit to brandond/rke2 that referenced this pull request Oct 14, 2024
@brandond
Sync kine changes from k3s-io/kine#325
7a51817 
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond added a commit to brandond/rke2 that referenced this pull request Oct 14, 2024
@brandond
Sync kine changes from k3s-io/kine#325
42932ca 
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond added a commit to brandond/rke2 that referenced this pull request Oct 14, 2024
@brandond
Sync kine changes from k3s-io/kine#325
f2a10ba 
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond added a commit to brandond/rke2 that referenced this pull request Oct 14, 2024
@brandond
Sync kine changes from k3s-io/kine#325
7b7f10e 
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond added a commit to brandond/rke2 that referenced this pull request Oct 14, 2024
@brandond
Sync kine changes from k3s-io/kine#325
a985d47 
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond added a commit to brandond/rke2 that referenced this pull request Oct 14, 2024
@brandond
Sync kine changes from k3s-io/kine#325
ddcbe63 
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond added a commit to brandond/rke2 that referenced this pull request Oct 14, 2024
@brandond
Sync kine changes from k3s-io/kine#325
121eadf 
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond added a commit to brandond/rke2 that referenced this pull request Oct 14, 2024
@brandond
Sync kine changes from k3s-io/kine#325
a9c883f 
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond added a commit to rancher/rke2 that referenced this pull request Oct 14, 2024
@brandond
Sync kine changes from k3s-io/kine#325
b624450 
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond added a commit to rancher/rke2 that referenced this pull request Oct 14, 2024
@brandond
Sync kine changes from k3s-io/kine#325
7d51083 
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond added a commit to rancher/rke2 that referenced this pull request Oct 14, 2024
@brandond
Sync kine changes from k3s-io/kine#325
d7a0f0f 
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond added a commit to rancher/rke2 that referenced this pull request Oct 14, 2024
@brandond
Sync kine changes from k3s-io/kine#325
35ef30c 
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond added a commit to rancher/rke2 that referenced this pull request Oct 15, 2024
@brandond
Sync kine changes from k3s-io/kine#325
fec6137 
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitorsavian vitorsavian vitorsavian approved these changes

@brandond brandond brandond approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider recognize postgresql:// network protocol
3 participants
@sambhav @brandond @vitorsavian