-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for non-root klipper-helm operation #29
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael DAmato <michaeldamato@MDD-MacBook-Pro.local>
mddamato
force-pushed
the
non-root-klipper
branch
from
July 7, 2021 15:28
5aae776
to
82e623f
Compare
brandond
requested changes
Jul 7, 2021
Signed-off-by: Michael DAmato <michaeldamato@MDD-MacBook-Pro.local>
brandond
requested changes
Jul 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit on the HOME variable; lgtm other than that
Signed-off-by: Michael DAmato <michaeldamato@MDD-MacBook-Pro.local>
brandond
approved these changes
Jul 7, 2021
briandowns
approved these changes
Jul 8, 2021
brandond
reviewed
Jul 8, 2021
brandond
requested changes
Jul 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found one more issue on final review.
Signed-off-by: Michael DAmato <michaeldamato@MDD-MacBook-Pro.local>
Signed-off-by: Michael DAmato <michaeldamato@MDD-MacBook-Pro.local>
brandond
requested changes
Jul 8, 2021
Signed-off-by: Michael DAmato <michaeldamato@MDD-MacBook-Pro.local>
brandond
approved these changes
Jul 8, 2021
It turns out that this doesn't actually work: ./helm --debug install traefik-crd https://10.43.0.1:443/static/charts/traefik-crd-10.1.1.tgz
install.go:173: [debug] Original chart version: ""
Error: Get "https://10.43.0.1:443/static/charts/traefik-crd-10.1.1.tgz": x509: certificate signed by unknown authority
helm.go:81: [debug] Get "https://10.43.0.1:443/static/charts/traefik-crd-10.1.1.tgz": x509: certificate signed by unknown authority |
This was referenced Aug 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
klipper-helm does not need to use the root user. In environments where policies prevent root users in containers without necessity, it is difficult to use this image.