Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for non-root klipper-helm operation #29

Merged
merged 6 commits into from
Jul 9, 2021

Conversation

mddamato
Copy link
Contributor

@mddamato mddamato commented Jul 7, 2021

klipper-helm does not need to use the root user. In environments where policies prevent root users in containers without necessity, it is difficult to use this image.

Signed-off-by: Michael DAmato <michaeldamato@MDD-MacBook-Pro.local>
package/Dockerfile Outdated Show resolved Hide resolved
package/Dockerfile Outdated Show resolved Hide resolved
package/Dockerfile Outdated Show resolved Hide resolved
entry Outdated Show resolved Hide resolved
Signed-off-by: Michael DAmato <michaeldamato@MDD-MacBook-Pro.local>
Copy link
Member

@brandond brandond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit on the HOME variable; lgtm other than that

package/Dockerfile Outdated Show resolved Hide resolved
Signed-off-by: Michael DAmato <michaeldamato@MDD-MacBook-Pro.local>
package/Dockerfile Outdated Show resolved Hide resolved
Copy link
Member

@brandond brandond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found one more issue on final review.

Michael DAmato added 2 commits July 8, 2021 16:30
Signed-off-by: Michael DAmato <michaeldamato@MDD-MacBook-Pro.local>
Signed-off-by: Michael DAmato <michaeldamato@MDD-MacBook-Pro.local>
@mddamato mddamato requested a review from brandond July 8, 2021 20:34
package/Dockerfile Outdated Show resolved Hide resolved
Signed-off-by: Michael DAmato <michaeldamato@MDD-MacBook-Pro.local>
@brandond brandond merged commit dc5a3a0 into k3s-io:master Jul 9, 2021
@brandond
Copy link
Member

brandond commented Aug 4, 2021

It turns out that this doesn't actually work:

./helm --debug install traefik-crd https://10.43.0.1:443/static/charts/traefik-crd-10.1.1.tgz
install.go:173: [debug] Original chart version: ""
Error: Get "https://10.43.0.1:443/static/charts/traefik-crd-10.1.1.tgz": x509: certificate signed by unknown authority
helm.go:81: [debug] Get "https://10.43.0.1:443/static/charts/traefik-crd-10.1.1.tgz": x509: certificate signed by unknown authority

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants