feat(rife): add support for rife v4.25 & v4.26 #1304
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #1303 , RIFE has updated lots of model after v4.6, the latest version number is 4.26 now, as v4.2x has been available for over 3 months, I think it's time to add support for the latest model.
The 4.2x model changed the padding factor in the flow, so I add that support in your
librife-ncnn-vulkan first, you can check them in your PR.
The second step is to fit the interface in video2x when calling librife, which is done in this commit.
Later, there needs a submodule update in next commit, which I'll do it asap when you merge the PR in librife.
NOTE:
I have test the linux ver. (compilation and run) on my personal server, however, the building env on windows is too complicated to setup (I don't want to install such huge VS and QT components on my personal computer), so I think there needs a test for windows ver. before you release the feature.
BTW, I really admire your amazing work on this video2x project, thank you.
Contact me at anytime if you need some help on maintaining or got questions on this PR, here's my address fdw22@mails.tsinghua.edu.cn.
Regards,
B1ACK917