Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rife): add support for rife v4.25 & v4.26 #1304

Merged
merged 3 commits into from
Jan 21, 2025
Merged

Conversation

B1ACK917
Copy link
Contributor

As mentioned in #1303 , RIFE has updated lots of model after v4.6, the latest version number is 4.26 now, as v4.2x has been available for over 3 months, I think it's time to add support for the latest model.

The 4.2x model changed the padding factor in the flow, so I add that support in your
librife-ncnn-vulkan first, you can check them in your PR.

The second step is to fit the interface in video2x when calling librife, which is done in this commit.

Later, there needs a submodule update in next commit, which I'll do it asap when you merge the PR in librife.

NOTE:
I have test the linux ver. (compilation and run) on my personal server, however, the building env on windows is too complicated to setup (I don't want to install such huge VS and QT components on my personal computer), so I think there needs a test for windows ver. before you release the feature.

BTW, I really admire your amazing work on this video2x project, thank you.

Contact me at anytime if you need some help on maintaining or got questions on this PR, here's my address fdw22@mails.tsinghua.edu.cn.

Regards,
B1ACK917

k4yt3x and others added 3 commits January 21, 2025 00:00
@B1ACK917
Copy link
Contributor Author

B1ACK917 commented Jan 21, 2025

Also, I got nearly every model after v4.6 converted to ncnn format, but I didn't add them to this repo due to the huge size, I think it's like hundreds of MB?

Due to the author in Practical-RIFE said "it is recommended to choose 4.25 by default for most scenes", I only added the 4.25 and 4.25-lite, plus the latest 4.26 version.

Please let me know if you want those models to be added, but I don't think it's a good idea to make the repo too huge.

Regards,
B

@k4yt3x k4yt3x linked an issue Jan 21, 2025 that may be closed by this pull request
@k4yt3x
Copy link
Owner

k4yt3x commented Jan 21, 2025

Amazing! Thanks for the PR. I'll review them ASAP.

I think we can add the models and I'll make some changes to the build scripts to prevent packaging the old models by default. Alternatively, I could host the old models on my file server or something for people that want to try them out to download so we avoid the clutter in the repo.

@k4yt3x
Copy link
Owner

k4yt3x commented Jan 21, 2025

Btw have you tested processing videos with this model? Does the output look ok?

And don't mind the pipeline errors. I'll do the tests manually. I'll also do the submodule update.

k4yt3x
k4yt3x previously approved these changes Jan 21, 2025
@k4yt3x k4yt3x merged commit 9d4b21b into k4yt3x:master Jan 21, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the supported Rife versions
2 participants