fix endpoint reconciliation (#1674)

The idea was to still trigger reconciliation cycles if resources changes by checking if there was a `generation` update.
https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#metadata
> generation: a sequence number representing a specific generation of the desired state. Set by the system and monotonically increasing, per-resource. May be compared, such as for RAW and WAW consistency.

However, the change caused a degradation in `Endpoints` resources. These resources don't have generation because they don't have a status. As a result, a reconciliation was only triggered on creation and deletion, but not on subset update.
This degradated also the behavior of the k8gb controller. The controller became too slow monitoring the health of applications since `Endpoints` updates no longer triggered a reconcile of the GSLB resource. This lead to slow failovers and failing e2e tests.

The solution proposed in this PR is to always trigger the `endpointMapHandler` function when an `Endpoint` resource changes. This is the same behavior as before #1652.

Signed-off-by: Andre Baptista Aguas <andre.aguas@protonmail.com>

Makefile

@@ -452,7 +452,7 @@ terratest: # Run terratest suite
 		echo -e "$(RED)Make sure you run the tests against at least two running clusters$(NC)" ;\
 		exit 1;\
 	fi
-	cd terratest/test/ && go mod download && CLUSTERS_NUMBER=$(RUNNING_CLUSTERS) go test -v -timeout 20m -parallel=12 --tags=$(TEST_TAGS)
+	cd terratest/test/ && go mod download && CLUSTERS_NUMBER=$(RUNNING_CLUSTERS) go test -v -timeout 25m -parallel=12 --tags=$(TEST_TAGS)
 
 .PHONY: website
 website:

controllers/gslb_controller_reconciliation.go

@@ -169,7 +169,6 @@ func (r *GslbReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.
 		return result.RequeueError(fmt.Errorf("getting GSLB servers (%s)", err))
 	}
 	gslb.Status.Servers = servers
-	fmt.Printf("got servers: %v\n", servers)
 
 	loadBalancerExposedIPs, err := refResolver.GetGslbExposedIPs(r.Client, r.Config.EdgeDNSServers)
 	if err != nil {

controllers/gslb_controller_setup.go

@@ -33,6 +33,7 @@ import (
 	"k8s.io/apimachinery/pkg/types"
 	ctrl "sigs.k8s.io/controller-runtime"
 	"sigs.k8s.io/controller-runtime/pkg/client"
+	"sigs.k8s.io/controller-runtime/pkg/client/apiutil"
 	"sigs.k8s.io/controller-runtime/pkg/controller/controllerutil"
 	"sigs.k8s.io/controller-runtime/pkg/event"
 	"sigs.k8s.io/controller-runtime/pkg/handler"
@@ -98,10 +99,21 @@ func (r *GslbReconciler) SetupWithManager(mgr ctrl.Manager) error {
 				if e.ObjectOld.GetGeneration() != e.ObjectNew.GetGeneration() {
 					return true
 				}
+
+				// endpoints don't have state, therefore they don't have a generation
+				// but when their subsets change they must be be reconciled
+				gvk, err := apiutil.GVKForObject(e.ObjectOld, r.Scheme)
+				if err != nil {
+					log.Warn().Msg("could not fetch GroupVersionKind for object")
+				} else if gvk.Kind == "Endpoints" {
+					return true
+				}
+
 				// Ignore reconciliation in case nothing has changed in k8gb annotations
 				oldAnnotations := e.ObjectOld.GetAnnotations()
 				newAnnotations := e.ObjectNew.GetAnnotations()
 				reconcile := !utils.EqualPredefinedAnnotations(oldAnnotations, newAnnotations, k8gbAnnotations...)
+
 				return reconcile
 			},
 		}).

controllers/logging/logr.go

@@ -61,6 +61,7 @@ func (a *logrSinkAdapter) Info(_ int, msg string, keysAndValues ...interface{})
 	a.WithValues(keysAndValues)
 	if a.name != "" {
 		a.z.Info().Msgf("%s: %s %s", a.name, msg, a.valuesAsJSON())
+		return
 	}
 	a.z.Info().Msgf("%s %s", msg, a.valuesAsJSON())
 }

deploy/edge/deployment.yaml

@@ -24,7 +24,7 @@ spec:
             name: zone-volume
       containers:
       - name: bind
-        image: internetsystemsconsortium/bind9:9.16
+        image: internetsystemsconsortium/bind9:9.18
         ports:
         - containerPort: 1053
           protocol: TCP

terratest/test/k8gb_weight_test.go

@@ -27,8 +27,6 @@ import (
 )
 
 func TestWeightsExistsInLocalDNSEndpoint(t *testing.T) {
-	t.Parallel()
-
 	tests := []struct {
 		gslbPath    string
 		ingressPath string