Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mandatory endpoints field #1332

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Add mandatory endpoints field #1332

merged 1 commit into from
Nov 9, 2023

Conversation

k0da
Copy link
Collaborator

@k0da k0da commented Nov 8, 2023

Fixes: error validating "": error validating data:
ValidationError(ServiceMonitor.spec): missing required field "endpoints" in com.coreos.monitoring.v1.ServiceMonitor.spec

..

HOW TO RUN CI ---

By default, all the checks will be run automatically. Furthermore, when changing website-related stuff, the preview will be generated by the netlify bot.

Heavy tests

Add the heavy-tests label on this PR if you want full-blown tests that include more than 2-cluster scenarios.

Debug tests

If the test suite is failing for you, you may want to try triggering Re-run all jobs (top right) with debug logging enabled. It will also make the print debug action more verbose.

  Fixes: error validating "": error validating data:
ValidationError(ServiceMonitor.spec): missing required field
"endpoints" in com.coreos.monitoring.v1.ServiceMonitor.spec

Signed-off-by: Dinar Valeev <k0da@opensuse.org>
Copy link
Member

@ytsarev ytsarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@k0da k0da merged commit 8132763 into k8gb-io:master Nov 9, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants