-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helm supports extra env, volumes and volume mounts for externaldns #1548
Conversation
…rnaldns Signed-off-by: abaguas <andre.aguas@protonmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abaguas that is great, thank you so much for this contribution!
I find your example for PR description extremely useful:
externaldns:
extraEnv:
- name: HTTPS_PROXY
value: http://proxy.example.com:8080
extraVolumes:
- name: ca-bundle
secret:
secretName: ca-proxy
extraVolumeMounts:
- name: ca-bundle
mountPath: /etc/ssl/certs
readOnly: true
Can you please add this example to documentation?
It can be a simple proxy.md
file to add too docs just mentioning this example with title Running k8gb behind a proxy
or similar.
Thanks!
Signed-off-by: abaguas <andre.aguas@protonmail.com>
✅ Deploy Preview for k8gb-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for k8gb-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thank you @ytsarev. Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing! Thanks a lot for the contribution!
Externaldns requires internet access to configure DNS records. In order to run it behind a proxy one needs to configure the proxy address using environment variables and to mount a volume containing the proxy CA certificate.
This can now be configured using the
externaldns.extraEnv
,externaldns.extraVolumes
andexternaldns.extraVolumeMounts
variables. Here is an example: