Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm supports extra env, volumes and volume mounts for externaldns #1548

Merged
merged 4 commits into from
May 14, 2024

Conversation

abaguas
Copy link
Collaborator

@abaguas abaguas commented May 1, 2024

Externaldns requires internet access to configure DNS records. In order to run it behind a proxy one needs to configure the proxy address using environment variables and to mount a volume containing the proxy CA certificate.
This can now be configured using the externaldns.extraEnv, externaldns.extraVolumes and externaldns.extraVolumeMounts variables. Here is an example:

externaldns:
  extraEnv:
  - name: HTTPS_PROXY
    value: http://proxy.example.com:8080
  extraVolumes:
  - name: ca-bundle
    secret:
      secretName: ca-proxy
  extraVolumeMounts:
  - name: ca-bundle
    mountPath: /etc/ssl/certs
    readOnly: true

…rnaldns

Signed-off-by: abaguas <andre.aguas@protonmail.com>
Copy link
Member

@ytsarev ytsarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abaguas that is great, thank you so much for this contribution!

I find your example for PR description extremely useful:

externaldns:
  extraEnv:
  - name: HTTPS_PROXY
    value: http://proxy.example.com:8080
  extraVolumes:
  - name: ca-bundle
    secret:
      secretName: ca-proxy
  extraVolumeMounts:
  - name: ca-bundle
    mountPath: /etc/ssl/certs
    readOnly: true

Can you please add this example to documentation?

It can be a simple proxy.md file to add too docs just mentioning this example with title Running k8gb behind a proxy or similar.

Thanks!

abaguas added 2 commits May 13, 2024 15:04
Signed-off-by: abaguas <andre.aguas@protonmail.com>
Signed-off-by: abaguas <andre.aguas@protonmail.com>
Copy link

netlify bot commented May 14, 2024

Deploy Preview for k8gb-preview ready!

Name Link
🔨 Latest commit 91cbf97
🔍 Latest deploy log https://app.netlify.com/sites/k8gb-preview/deploys/6642b89f4bbcc90008408009
😎 Deploy Preview https://deploy-preview-1548--k8gb-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 14, 2024

Deploy Preview for k8gb-preview ready!

Name Link
🔨 Latest commit 191adb8
🔍 Latest deploy log https://app.netlify.com/sites/k8gb-preview/deploys/6642b93c0178150008f2b92d
😎 Deploy Preview https://deploy-preview-1548--k8gb-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@abaguas
Copy link
Collaborator Author

abaguas commented May 14, 2024

@abaguas that is great, thank you so much for this contribution!

I find your example for PR description extremely useful:

externaldns:
  extraEnv:
  - name: HTTPS_PROXY
    value: http://proxy.example.com:8080
  extraVolumes:
  - name: ca-bundle
    secret:
      secretName: ca-proxy
  extraVolumeMounts:
  - name: ca-bundle
    mountPath: /etc/ssl/certs
    readOnly: true

Can you please add this example to documentation?

It can be a simple proxy.md file to add too docs just mentioning this example with title Running k8gb behind a proxy or similar.

Thanks!

Thank you @ytsarev. Done!

Signed-off-by: abaguas <andre.aguas@protonmail.com>
Copy link
Member

@ytsarev ytsarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Thanks a lot for the contribution!

@ytsarev ytsarev merged commit 27d87ce into k8gb-io:master May 14, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants