Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Release instructions with chart readme version bump #1639

Merged
merged 1 commit into from
Jul 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -335,6 +335,11 @@ make demo DEMO_URL=https://failover.test.exampledns.tk DEMO_DEBUG=1

* Bump the version in `Chart.yaml`, see [example PR](https://github.com/k8gb-io/k8gb/pull/749). Make sure the
commit message starts with `RELEASE:`.
* In addition, bump the version in `chart/k8gb/README.md` to reflect correct version tags in artifacthub after
release, e.g.
```
chart/k8gb/README.md:![Version: v0.13.0](https://img.shields.io/badge/Version-v0.13.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: v0.13.0](https://img.shields.io/badge/AppVersion-v0.13.0-informational?style=flat-square)
```
* Merge the Pull Request after the review approval (make sure the squash or rebase is used, merge commit will not trigger the release pipeline)
* At this point a DRAFT release will be created on GitHub. After the [automatic tag](https://github.com/k8gb-io/k8gb/actions/workflows/cut_release.yaml) & [release pipeline](https://github.com/k8gb-io/k8gb/actions/workflows/release.yaml)
have been successfully completed, you check the [release DRAFT](https://github.com/k8gb-io/k8gb/releases) and if it is OK, you click on the **"Publish release"** button.
Expand Down
2 changes: 1 addition & 1 deletion chart/k8gb/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ maintainers:
name: Jiri Kremser
- email: kuritka@gmail.com
name: Michal Kuritka
- email: yury.tsarev@absa.africa
- email: yury@upbound.io
name: Yury Tsarev

annotations:
Expand Down
2 changes: 1 addition & 1 deletion chart/k8gb/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ A Helm chart for Kubernetes Global Balancer
| Dinar Valeev | <dinar.valeev@absa.africa> | |
| Jiri Kremser | <jiri.kremser@gmail.com> | |
| Michal Kuritka | <kuritka@gmail.com> | |
| Yury Tsarev | <yury.tsarev@absa.africa> | |
| Yury Tsarev | <yury@upbound.io> | |

## Source Code

Expand Down
Loading