Time measure failover process #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Move failover check retry functions to subtest
to enable gathering of time metrics from the test suite
* Current results look like:
```
--- PASS: TestOhmyglbBasicFailoverExample (289.48s)
--- PASS: TestOhmyglbBasicFailoverExample/failover_happens_as_expected (157.23s)
PASS
ok ohmyterratest 291.032s
```
* This way we objectively measured that the whole failover process
(CRD->etcd->coredns) update takes more than 2.5 minutes
There is definitely something to improve.
donovanmuller
approved these changes
Apr 8, 2020
kuritka
approved these changes
Apr 8, 2020
somaritane
approved these changes
Apr 8, 2020
ytsarev
added a commit
that referenced
this pull request
Apr 8, 2020
* Reduce external-dns ( CRD -> etcd ) sync interval to 20s
* Value is picked to be sligtly below default 30s DNS TTL
we are currently working with
* Terratest results:
```
--- PASS: TestOhmyglbBasicFailoverExample (157.84s)
--- PASS: TestOhmyglbBasicFailoverExample/failover_happens_as_expected (35.41s)
```
* This way we reduced failover(or any kind of load balancing
reconfiguration) from ~2.5 min down to 35 seconds
See #80 for initial values
ytsarev
added a commit
that referenced
this pull request
Apr 8, 2020
* Reduce external-dns ( CRD -> etcd ) sync interval to 20s
* Value is picked to be sligtly below default 30s DNS TTL
we are currently working with
* Terratest results:
```
--- PASS: TestOhmyglbBasicFailoverExample (157.84s)
--- PASS: TestOhmyglbBasicFailoverExample/failover_happens_as_expected (35.41s)
```
* This way we reduced failover(or any kind of load balancing
reconfiguration) from ~2.5 min down to 35 seconds
See #80 for initial values
kuritka
pushed a commit
that referenced
this pull request
Apr 15, 2020
* Reduce external-dns ( CRD -> etcd ) sync interval to 20s
* Value is picked to be sligtly below default 30s DNS TTL
we are currently working with
* Terratest results:
```
--- PASS: TestOhmyglbBasicFailoverExample (157.84s)
--- PASS: TestOhmyglbBasicFailoverExample/failover_happens_as_expected (35.41s)
```
* This way we reduced failover(or any kind of load balancing
reconfiguration) from ~2.5 min down to 35 seconds
See #80 for initial values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to enable gathering of time metrics from the test suite
(CRD->etcd->coredns) update takes more than 2.5 minutes
There is definitely something to improve.