Upgrade licenses

[kuritka]

• update .licignore to contain /terratests, main.go, and gslb_controller.go.
• remove old license from source code and terratests
• place license on the new place in the go files (under package *\n)
• update build pipeline (build.yml)
• bump golic to v0.7.2

# golic@v0.5.0
golic remove -t apache2
# golic@v0.7.2
golic inject -t apache2

Signed-off-by: kuritka kuritka@gmail.com

[jkremser]

so if we re-run the mock generation, is it going to be ok w/ golic?

[kuritka]

sure, it always inject license into it, see: https://github.com/k8gb-io/k8gb/blob/master/Makefile#L374

[ytsarev]

place license on the new place in the go files (under package *\n)

curious about this change. Was it breaking something with the license header before package?

[kuritka]

@ytsarev, thx for question.

A valid go file structure can be :

 /* 
   optional comment
 */
 
 // Package xyz optional comment,  if it exists, it must start with 'Package xyz' otherwise linters may shout. e.g: idea goland always warns. 
 package xyz
 ...

the problem starts when go directives are introduced, which must be in a certain place in the file - for example at the beginning:

//go:build !ignore_autogenerated
// +build !ignore_autogenerated

// ^^ directives must be on the top...
// Package xyz defines....
package xyz

In such case, finding a place to inject the licence is more difficult.

finding a place for the license would be significantly harder, but not impossible:

• Either we would have to specify files in k8gb/.golic.yaml that would generate the license under //go:build clauses (otherwise on top). With new files, we would have to edit the file from time to time.
• Or edit golic again and iterate through the comments preceding the package definition until a space is found between the comments and the GO directives.

[ytsarev]

@kuritka that makes total sense, thanks for the explanation