Always run terratest_log_parser and upload the artifact #896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jirka Kremser <jiri.kremser@gmail.com>
jkremser
requested review from
donovanmuller,
k0da,
kuritka,
somaritane and
ytsarev
as code owners
kuritka
approved these changes
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running the
terratest_log_parserand uploading the zip with the logs makes especially sense if there is an error so that one can debug it. However currently, if there is a failure the subsequent tasks are not being run.Other option would be having
if failure()there but why not to have the nice logs even for success?continue-on-error: truewould not work because it would make the pipeline green even if there is an issue.Example of such pipeline with an error but the logs were not processed: https://github.com/k8gb-io/k8gb/runs/6706323648?check_suite_focus=true
Signed-off-by: Jirka Kremser jiri.kremser@gmail.com