-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Question]: should not use the history event for the pdb checking #476
Comments
4 tasks
jianzhangbjz
added a commit
to jianzhangbjz/k8sgpt
that referenced
this issue
Jun 6, 2023
The PDB event is a historical record, it's not a good choice to judge the pdb latest status based on it. So, use the `stataus` instead of `event` to check it. Closes: k8sgpt-ai#476 Signed-off-by: Jian Zhang <jiazha@redhat.com>
jianzhangbjz
added a commit
to jianzhangbjz/k8sgpt
that referenced
this issue
Jun 6, 2023
The PDB event is a historical record, it's not a good choice to judge the pdb latest status based on it. So, use the `stataus` instead of `event` to check it. Closes: k8sgpt-ai#476 Signed-off-by: Jian Zhang <jiazha@redhat.com>
AlexsJones
pushed a commit
that referenced
this issue
Jun 7, 2023
The PDB event is a historical record, it's not a good choice to judge the pdb latest status based on it. So, use the `stataus` instead of `event` to check it. Closes: #476 Signed-off-by: Jian Zhang <jiazha@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Checklist
Affected Components
K8sGPT Version
k8sgpt: 0.3.6 (9c0efe6), built at: unknown
Kubernetes Version
No response
Host OS and its Version
Mac OS 12.6.6
Steps to reproduce
$ k8sgpt analyze
Expected behaviour
No error report for the PDB(
PodDisruptionBudget
).Actual behaviour
Additional Information
The PDB works as expected, and it already found the matched pods, but the history event is preserved. We shouldn't use the
event
to judge if the pdb works well.The text was updated successfully, but these errors were encountered: