Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove show password in auth list #1061

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

yankay
Copy link
Contributor

@yankay yankay commented Apr 11, 2024

Closes #936

πŸ“‘ Description

Because the feature of show password has been removed by #695.

So clean the code of userInput

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

β„Ή Additional Information

@yankay yankay requested review from a team as code owners April 11, 2024 07:01
@yankay yankay force-pushed the remove-userInput branch from 23fe137 to 15e8121 Compare April 11, 2024 07:02
Signed-off-by: Kay Yan <kay.yan@daocloud.io>
@yankay yankay force-pushed the remove-userInput branch from 15e8121 to e1fecd8 Compare April 11, 2024 07:09
Copy link
Contributor

@JuHyung-Son JuHyung-Son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

welcome to k8sgpt

Copy link
Contributor

@matthisholleville matthisholleville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AlexsJones AlexsJones merged commit 9e02637 into k8sgpt-ai:main Apr 16, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Bug]: auth list doesn't show password even if user input is set
5 participants