Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: added Windows and Linux installation steps in README #116

Merged
merged 1 commit into from
Mar 28, 2023
Merged

docs: added Windows and Linux installation steps in README #116

merged 1 commit into from
Mar 28, 2023

Conversation

sai-kumar-peddireddy
Copy link
Contributor

@sai-kumar-peddireddy sai-kumar-peddireddy commented Mar 28, 2023 •
edited
Loading

Closes #105

📑 Description

  • Improved current README by adding clear windows installation steps with path configuration.

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

Sample output

image

@sai-kumar-peddireddy sai-kumar-peddireddy requested a review from a team as a code owner March 28, 2023 12:47
AlexsJones
AlexsJones reviewed Mar 28, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
AlexsJones
AlexsJones reviewed Mar 28, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
AlexsJones
AlexsJones reviewed Mar 28, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
AlexsJones
AlexsJones requested changes Mar 28, 2023
View reviewed changes
Copy link
Member

@AlexsJones AlexsJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing, a few suggestions

@sai-kumar-peddireddy sai-kumar-peddireddy force-pushed the readme-improvements branch 3 times, most recently from 63b97ed to 61bd597 Compare March 28, 2023 13:02
@sai-kumar-peddireddy sai-kumar-peddireddy changed the title Added Windows and Linux instalation steps in README docs: Added Windows and Linux instalation steps in README Mar 28, 2023
@sai-kumar-peddireddy sai-kumar-peddireddy changed the title docs: Added Windows and Linux instalation steps in README docs: added Windows and Linux instalation steps in README Mar 28, 2023
@sai-kumar-peddireddy
docs: added Windows and Linux instalation steps in README
f3e2d09 
Signed-off-by: sai_kumar_peddireddy <sai.peddireddy77@gmail.com>
thschue
thschue approved these changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@thschue thschue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thschue thschue merged commit 3bfb278 into k8sgpt-ai:main Mar 28, 2023
@github-actions github-actions bot mentioned this pull request Mar 28, 2023
Merged
@sai-kumar-peddireddy sai-kumar-peddireddy changed the title docs: added Windows and Linux instalation steps in README docs: added Windows and Linux installation steps in README Mar 28, 2023
fyuan1316 pushed a commit to fyuan1316/k8sgpt that referenced this pull request Jun 26, 2023
@renovate
fix(deps): update module sigs.k8s.io/controller-runtime to v0.15.0 (k…
49fab66 
…8sgpt-ai#116)

Signed-off-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexsJones AlexsJones AlexsJones requested changes

@thschue thschue thschue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add installation instructions for installation from releases
3 participants
@sai-kumar-peddireddy @AlexsJones @thschue