Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add handling of CreateContainerConfigError error #639

Merged
merged 6 commits into from
Nov 12, 2023

Conversation

tsadoklf
Copy link
Contributor

@tsadoklf tsadoklf commented Sep 10, 2023

Add handling of CreateContainerConfigError error

Closes #

πŸ“‘ Description

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

β„Ή Additional Information

Added handling of CreateContainerConfigError error

Signed-off-by: Tsadok Levi Firseck <tsadoklf@gmail.com>
@tsadoklf tsadoklf requested review from a team as code owners September 10, 2023 09:42
@arbreezy
Copy link
Member

arbreezy commented Sep 19, 2023

@tsadoklf Lgtm, please amend your git commit messages to comply with our semantics

@thschue thschue changed the title Update pod.go: Add handling of CreateContainerConfigError error feat: add handling of CreateContainerConfigError error Nov 12, 2023
Copy link
Contributor

@thschue thschue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thschue thschue merged commit 1a554ae into k8sgpt-ai:main Nov 12, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants