add ibKubernetesEnabled config #38
Conversation
README.md
Outdated
| * `ipam` (dictionary, optional): IPAM configuration to be used for this network, `dhcp` is not supported. | ||
| * `link_state` (string, optional): Enforces link state for the VF. Allowed values: auto, enable, disable. | ||
| * `rdmaIsolation` (boolean, optional): Enable RDMA network namespace isolation for RDMA workloads. More information | ||
| about the system requirements to support this mode of operation can be found [here](https://github.com/Mellanox/rdma-cni) | ||
| * `cniArgGUID` (bool, optional): Enforces ib-sriov-cni to get VF GUID from CNI-Args["mellanox.infiniband.app"], default to false. CNI-Args["mellanox.infiniband.app"] is configured by [ib-kubernetes](https://www.github.com/Mellanox/ib-kubernetes). |
There was a problem hiding this comment.
working with ib-kubernetes we still allow to get GUID from CNI args. I think we need to change the name to IBKubernetesEnabled or something similar
cmd/ib-sriov-cni/main.go
Outdated
| @@ -39,14 +39,18 @@ func init() { | |||
| } | |||
|
|
|||
| func getGUIDFromConf(netConf *localtypes.NetConf) (string, error) { | |||
| // Take from CNI_ARGS if available | |||
| if netConf.CniArgGUID { | |||
| if guid, ok := netConf.Args.CNI["guid"]; ok { | |||
There was a problem hiding this comment.
so you need to move the RuntimeConfig.InfinibandGUID to here as well (Line 50). We will use this once InfinibandGUID will be approved by the network-att-def same as mac see [1]
[1] https://docs.google.com/document/d/1V0R_MEiPapZOD_SuBjzTOdGYqILBFovuy1xacYCqFHg/edit
There was a problem hiding this comment.
Done.
I thought with ib-kubernetes, it only allocates GUID for VF device, but it actually respect what's allocated in CNI_ARGS["guid"].
pkg/types/types.go
Outdated
| LinkState string `json:"link_state,omitempty"` // auto|enable|disable | ||
| RdmaIso bool `json:"rdmaIsolation,omitempty"` | ||
| IBKubernetesEnabled bool `json:"ibKubernetesEnabled,omitempty"` | ||
| RdmaNetState rdmatypes.RdmaNetState |
There was a problem hiding this comment.
gofmt error:
pkg/types/types.go:27: File is not gofmt-ed with -s (gofmt)
RdmaNetState rdmatypes.RdmaNetState
Args struct {
Makefile:74: recipe for target 'lint' failed
make: *** [lint] Error 1
No description provided.