Make sure that policies with no valid peers are enforced #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a policy rule has a `from` (or `to`) selector that matches no pods,
the subject pod has to not be reached by (or has to not reach) any pods.
The following example helps clarify the reasons behind these:
Given a scenario with 3 pods (A, B, C) and a rule like:
```
podSelector:
matchLabels:
name: A
ingress:
- from:
- podSelector:
matchLabels:
name: B
policyTypes:
- Ingress
```
Pod A can be reached only by pod B. Pod C can't reach A, and this has to be
ensured even if pod B is deleted.
Add an end-to-end test case to validate this scenario and adjust unit
tests accordingly.
Signed-off-by: Andrea Panattoni <apanatto@redhat.com>
Signed-off-by: Andrea Panattoni <apanatto@redhat.com>
Pull Request Test Coverage Report for Build 9993738204Details
💛 - Coveralls |
| @@ -280,7 +280,6 @@ func (ipt *iptableBuffer) renderIngressFrom(s *Server, podInfo *controllers.PodI | |||
| writeLine(ipt.policyIndex, "-A", fmt.Sprintf("MULTI-%d-INGRESS", pIndex), "-j", chainName) | |||
|
|
|||
| s.podMap.Update(s.podChanges) | |||
| validPeers := 0 | |||
There was a problem hiding this comment.
it seems to me that you don't need to count. This could be a boolean and switches to true when there is at least one valid peer
There was a problem hiding this comment.
I completely removed that variable, as in my idea there is no need to check if there is at least one valid peer. Does it sound good?
There was a problem hiding this comment.
right, I did not see it correctly
|
/assign bpickard22 |
|
LGTM |
|
@pliurh @bpickard22 can I somehow help to move this forward? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a policy rule has a
from(orto) selector that matches no pods, the subject pod has to not be reached by (or has to not reach) any pods.The following example helps clarify the reasons behind these: Given a scenario with 3 pods (A, B, C) and a rule like:
Pod A can be reached only by pod B. Pod C can't reach A, and this has to be ensured even if pod B is deleted.
Add an end-to-end test case to validate this scenario and adjust unit tests accordingly.
cc @pliurh @s1061123