Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change libcni's cache directory from default for multus delegates #638

Merged
merged 1 commit into from
Mar 29, 2021
Merged

Change libcni's cache directory from default for multus delegates #638

merged 1 commit into from
Mar 29, 2021

Conversation

s1061123
Copy link
Member

@s1061123 s1061123 commented Mar 26, 2021 •
edited
Loading

This changes CNI cache directory to non default places to avoid conflicts among CNI runtimes.

@s1061123
Change libcni's cache directory from default for multus delegates
75acc10 
This changes CNI cache directory to non default places to avoid
conflicts among CNI runtimes.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 691017580

  • 43 of 43 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.796%
Totals Coverage Status
Change from base Build 684433578: 0.0%
Covered Lines: 1143
Relevant Lines: 1592
💛 - Coveralls

@s1061123 s1061123 requested a review from dougbtv March 26, 2021 19:34
dougbtv
dougbtv approved these changes Mar 29, 2021
View reviewed changes
Copy link
Member

@dougbtv dougbtv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dougbtv dougbtv merged commit ae56437 into k8snetworkplumbingwg:master Mar 29, 2021
@s1061123 s1061123 mentioned this pull request Apr 7, 2021
Open
@s1061123 s1061123 deleted the dev/use-non-default-libcni-cache branch May 21, 2021 16:43
@coveralls
Copy link

Coverage Status

Changes unknown
when pulling 75acc10 on s1061123:dev/use-non-default-libcni-cache
into ** on k8snetworkplumbingwg:master**.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougbtv dougbtv dougbtv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@s1061123 @coveralls @dougbtv