Remove usage of k8s api certificates/v1beta1 and use self signed certificate #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianchiris
approved these changes
Oct 5, 2021
e0ne
approved these changes
Oct 5, 2021
|
@zshi-redhat can you take a quick look |
zshi-redhat
approved these changes
Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
K8s release 1.22 onwards k8s.io/api/certificates/v1beta1 will not be supported and with certificates.k8s.io/v1 the k8s signers are designed to be used only for k8s internal services. This PR introduces self signed certificates for NRI webhook server instead of using k8s signers.
Fixes: #111