Make it easier for the end user to debug issues with their sriov config #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this patch the config is logged before the error is returned. When the user looks through the logs they will be able to see their config, along with a message asking them to check if config is in json format. Signed-off-by: John O'Loughlin <john.oloughlin@intel.com>
johnoloughlin
changed the title
cmd/sriovdp/manager.go
Outdated
| if err = json.Unmarshal(rawBytes, resources); err != nil { | ||
| return fmt.Errorf("error unmarshalling raw bytes %v", err) | ||
| return fmt.Errorf("error unmarshalling raw bytes %v\n please make sure the config is in json format \n", err) |
There was a problem hiding this comment.
nit: mind dropping the \n ?
i.e
fmt.Errorf("error unmarshalling raw bytes %v. please make sure the config is in json format", err)
zshi-redhat
approved these changes
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this patch the config is logged before the error is returned.
When the user looks through the logs they will be able to see their config,
along with a message asking them to check if config is in json format.
Signed-off-by: John O'Loughlin john.oloughlin@intel.com