allow dash "-" in resource name #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4803214811Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
just need to sort UT in |
according to https://github.com/kubernetes/kubernetes/blob/b1f901acf44f8adf69759db434690c2a8bdd616b/staging/src/k8s.io/kubelet/pkg/apis/deviceplugin/v1beta1/api.proto#L41, resource name is expected to be a DNS lable so dash should be allowed Fixes: k8snetworkplumbingwg#476
done. Thanks for pointing it out. |
adrianchiris
approved these changes
May 2, 2023
|
@adrianchiris do we need anything else before merging this? |
|
you need additional LGTM. already asked the folks in yesterday's meeting. |
Eoghan1232
approved these changes
May 8, 2023
|
lgtm |
ian-howell
pushed a commit
to ian-howell/sriov-network-device-plugin
that referenced
this pull request
Jun 2, 2023
according to https://github.com/kubernetes/kubernetes/blob/b1f901acf44f8adf69759db434690c2a8bdd616b/staging/src/k8s.io/kubelet/pkg/apis/deviceplugin/v1beta1/api.proto#L41, resource name is expected to be a DNS lable so dash should be allowed Fixes: k8snetworkplumbingwg#476
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
according to
https://github.com/kubernetes/kubernetes/blob/b1f901acf44f8adf69759db434690c2a8bdd616b/staging/src/k8s.io/kubelet/pkg/apis/deviceplugin/v1beta1/api.proto#L41, resource name is expected to be a DNS lable so dash should be allowed
Fixes: #476