Downgrade ddp-builder container version #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrading to golang:1.21-alpine3.19 caused the ddp build to fail. Downgrade it until the root cause is found Signed-off-by: amaslennikov <amaslennikov@nvidia.com>
Pull Request Test Coverage Report for Build 7799246143
💛 - Coveralls |
SchSeba
reviewed
Feb 12, 2024
| @@ -10,7 +10,7 @@ WORKDIR /usr/src/sriov-network-device-plugin | |||
| RUN make clean && \ | |||
| make build | |||
|
|
|||
| FROM golang:1.21-alpine3.19 as ddp-builder | |||
| FROM golang:1.20-alpine3.16 as ddp-builder | |||
There was a problem hiding this comment.
I think a better idea will be to have a different container for the ddp tool we want the go code to be on 1.21
There was a problem hiding this comment.
I propose to address this in a separate PR, so that we unblock the image build first
There was a problem hiding this comment.
The go code is built with golang 1.21, ddp uses a different layer
There was a problem hiding this comment.
@SchSeba can you please open an issue on this ?
There was a problem hiding this comment.
oh it was already done sorry I miss it...
|
@Eoghan1232 PTAL, currently build&push image GA workflow is failing, this should fix it. |
Eoghan1232
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading to golang:1.21-alpine3.19 caused the ddp build to fail: https://github.com/k8snetworkplumbingwg/sriov-network-device-plugin/actions/runs/7738698140
Let's downgrade it until the root cause is found