allow to run unit-tests inside a container #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 9338101632Details
💛 - Coveralls |
adrianchiris
reviewed
Jun 2, 2024
pkg/utils/testing.go
Outdated
| } | ||
| //nolint: gocritic | ||
| pciIdsPath := filepath.Join(dir, "../../pkg/utils/testdata/pci.ids") | ||
| pciData, err = os.ReadFile(pciIdsPath) |
There was a problem hiding this comment.
i think for tests we can always use this file. less variation when running test. WDYT ?
adrianchiris
reviewed
Jun 2, 2024
SchSeba
force-pushed
the
fix_unittest
branch
2 times, most recently
from
3fd63bb to
103ce99
Compare
Signed-off-by: Sebastian Sch <sebassch@gmail.com>
Signed-off-by: Sebastian Sch <sebassch@gmail.com>
Signed-off-by: Sebastian Sch <sebassch@gmail.com>
adrianchiris
approved these changes
Jun 2, 2024
adrianchiris
merged commit 3ffbe14
into
k8snetworkplumbingwg:master
10 of 11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.