Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip config if policy not applied yet #287

Merged
merged 1 commit into from
Jul 14, 2022
Merged

Skip config if policy not applied yet #287

merged 1 commit into from
Jul 14, 2022
+19 −0

Commits on Jul 13, 2022

  1. Skip config if policy not applied yet 

    There is a stage when the SriovNetworkNodeState is initializing
where the spec is empty because the SriovNetworkNodePolicyReconciler
did not yet applied the policies.

It can cause a non required action by the plugins,
that will try to apply the empty spec by resetting the NIC for example.

The config daemon will not run the plugins if the generation is 1
and the Spec.Interfaces is empty.

Solves issue k8snetworkplumbingwg#283

For e2e tests, the wait timeout to get to initial Sync state has been
increased.
This change is needed as now the config daemon will not apply on "empty"
spec until the SriovNetworkNodePolicyReconciler will iterate on the Interfaces.
The reconcile loop interval is 5 minutes, so the test timeout needed to be increased.

Signed-off-by: Fred Rolland <frolland@nvidia.com>
    @rollandf
    rollandf committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    47ac214 View commit details
    Browse the repository at this point in the history