Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sriov-network-config-daemon crash when configmap cannot be obtained #391

Merged

Conversation

jkossak
Copy link
Contributor

@jkossak jkossak commented Dec 14, 2022

This PR adds a line to crash sriov-network-config-daemon if it can't access the configmap with NIC interfaces.
Fixes #390

@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@zeeke
Copy link
Member

zeeke commented Dec 15, 2022

Makes sense to me. I'm not aware of any scenario in which the config-daemon can work without InitNicIDs successfully initialized.

@SchSeba I think this should not clash with #365 , as the service implementation would use another function to obtain the map. Right?

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3695580961

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 10 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.05%) to 25.223%

Files with Coverage Reduction New Missed Lines %
controllers/sriovibnetwork_controller.go 2 65.35%
controllers/sriovnetwork_controller.go 2 69.0%
api/v1/helper.go 6 40.6%
Totals Coverage Status
Change from base Build 3631034070: -0.05%
Covered Lines: 1894
Relevant Lines: 7509

💛 - Coveralls

@SchSeba
Copy link
Collaborator

SchSeba commented Dec 18, 2022

/lgtm

@github-actions github-actions bot added the lgtm label Dec 18, 2022
@SchSeba SchSeba merged commit 2733f11 into k8snetworkplumbingwg:master Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sriov-network-config-daemon should crash if configmap with NIC interfaces cannot be obtained
5 participants