Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update go to 1.19 #397

Merged
merged 1 commit into from
Jan 17, 2023
Merged

Update go to 1.19 #397

merged 1 commit into from
Jan 17, 2023

Conversation

bn222
Copy link
Collaborator

@bn222 bn222 commented Jan 17, 2023

Signed-off-by: Balazs Nemeth bnemeth@redhat.com

@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@coveralls
Copy link

coveralls commented Jan 17, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 3941063049

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.2%) to 25.503%
Files with Coverage Reduction New Missed Lines %
controllers/sriovnetwork_controller.go 2 69.0%
controllers/sriovnetworkpoolconfig_controller.go 4 56.39%
Totals Coverage Status
Change from base Build 3941032365: 0.2%
Covered Lines: 1915
Relevant Lines: 7509
💛 - Coveralls

@adrianchiris
Copy link
Collaborator

in project dockerfiles point to base image with go1.18 these should be adjusted as well no ?

@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@bn222
Copy link
Collaborator Author

bn222 commented Jan 17, 2023

in project dockerfiles point to base image with go1.18 these should be adjusted as well no ?

Good catch. Updated it.

@bn222
Update go to 1.19
4ab1bda 
Signed-off-by: Balazs Nemeth <bnemeth@redhat.com>
@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

adrianchiris
adrianchiris approved these changes Jan 17, 2023
View reviewed changes
Copy link
Collaborator

@adrianchiris adrianchiris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

SchSeba
SchSeba approved these changes Jan 17, 2023
View reviewed changes
Copy link
Collaborator

@SchSeba SchSeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@SchSeba SchSeba merged commit 7d4954f into k8snetworkplumbingwg:master Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianchiris adrianchiris adrianchiris approved these changes

@SchSeba SchSeba SchSeba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bn222 @coveralls @adrianchiris @SchSeba