Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage, etcd: remove backend #240

Merged
merged 2 commits into from
Aug 9, 2022

Conversation

maiqueb
Copy link
Collaborator

@maiqueb maiqueb commented Jun 24, 2022

Fixes: #231

This is a breaking API change.

@maiqueb maiqueb requested a review from dougbtv as a code owner June 24, 2022 07:30
@coveralls
Copy link

coveralls commented Jun 24, 2022

Pull Request Test Coverage Report for Build 2690322800

  • 5 of 9 (55.56%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+5.8%) to 65.053%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/config/config.go 1 5 20.0%
Files with Coverage Reduction New Missed Lines %
cmd/whereabouts.go 1 77.53%
pkg/config/config.go 1 55.29%
Totals Coverage Status
Change from base Build 2656571269: 5.8%
Covered Lines: 927
Relevant Lines: 1425

💛 - Coveralls

@maiqueb maiqueb mentioned this pull request Jul 5, 2022
maiqueb added 2 commits July 18, 2022 13:53
Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
@maiqueb maiqueb force-pushed the remove-etcd-backend branch from 72df15b to d425c31 Compare July 18, 2022 11:57
Copy link
Member

@dougbtv dougbtv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Miguel and I discussed the method by which we're removing the etcd support, with the consideration of "what if we add another backend in the future?" -- the outcome as suggested by Miguel was that we should expose the API in such way as to not need the handler as it's used today, and I concur, it's a better approach.

@dougbtv
Copy link
Member

dougbtv commented Aug 9, 2022

Additionally -- it works in my lab ;) 👍

@dougbtv dougbtv merged commit 428d2b3 into k8snetworkplumbingwg:master Aug 9, 2022
@maiqueb
Copy link
Collaborator Author

maiqueb commented Aug 10, 2022

@dougbtv we need to make sure this change is listed in the release notes of the next release.

@maiqueb maiqueb deleted the remove-etcd-backend branch August 10, 2022 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

etcd deprecation
3 participants