Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit label and annotation restrictions in AdditionalServiceConfig #689

Closed
olim7t opened this issue Aug 23, 2024 · 0 comments · Fixed by #690
Closed

Revisit label and annotation restrictions in AdditionalServiceConfig #689

olim7t opened this issue Aug 23, 2024 · 0 comments · Fixed by #690
Labels
bug Something isn't working done Issues in the state 'done'

Comments

@olim7t
Copy link
Contributor

olim7t commented Aug 23, 2024

cass-operator does not allow label and annotation keys that start with cassandra.datastax.com or k8ssandra.io in AdditionalServiceConfig (source). This is intended to prevent collisions with the labels that the operator uses internally.

However, k8ssandra-operator, which relies on cass-operator to manage its datacenters, also uses the k8ssandra.io prefix. There are cases where it might need to label services for its own internal needs, but this is currently not possible.
@olim7t olim7t added the bug Something isn't working label Aug 23, 2024
olim7t added a commit to olim7t/cass-operator that referenced this issue Aug 23, 2024
@olim7t
Allow some internal labels and annotaions in services config (fixes k…
26fe263 
…8ssandra#689)
@olim7t olim7t mentioned this issue Aug 23, 2024
Merged
5 tasks
@olim7t olim7t moved this to Ready For Review in K8ssandra Aug 23, 2024
@adejanovski adejanovski added the ready-for-review Issues in the state 'ready-for-review' label Aug 23, 2024
olim7t added a commit to olim7t/cass-operator that referenced this issue Aug 23, 2024
@olim7t
Allow some internal labels and annotations in services config (fixes k…
1e551db 
…8ssandra#689)
@olim7t olim7t mentioned this issue Aug 24, 2024
Merged
5 tasks
@burmanm burmanm moved this from Ready For Review to Review in K8ssandra Aug 26, 2024
@adejanovski adejanovski added review Issues in the state 'review' and removed ready-for-review Issues in the state 'ready-for-review' labels Aug 26, 2024
olim7t added a commit to olim7t/cass-operator that referenced this issue Aug 26, 2024
@olim7t
Allow k8ssandra.io labels and annotations in services config (fixes k…
0b8f3f6 
…8ssandra#689)
olim7t added a commit to olim7t/cass-operator that referenced this issue Aug 26, 2024
@olim7t
Allow k8ssandra.io labels and annotations in services config (fixes k…
ed00175 
…8ssandra#689)
olim7t added a commit to olim7t/cass-operator that referenced this issue Aug 27, 2024
@olim7t
Allow k8ssandra.io labels and annotations in services config (fixes k…
5609e20 
…8ssandra#689)
olim7t added a commit to olim7t/cass-operator that referenced this issue Aug 27, 2024
@olim7t
Allow k8ssandra.io labels and annotations in services config (fixes k…
81bc8e9 
…8ssandra#689)
@olim7t olim7t closed this as completed in af6648a Aug 27, 2024
@github-project-automation github-project-automation bot moved this from Review to Done in K8ssandra Aug 27, 2024
@adejanovski adejanovski added done Issues in the state 'done' and removed review Issues in the state 'review' labels Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working done Issues in the state 'done'
Projects
No open projects
K8ssandra
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow k8ssandra.io labels and annotations in services config (fixes #689) olim7t/cass-operator
2 participants
@olim7t @adejanovski