Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new defaults for memory and CPU for sidecars #517

Merged
merged 1 commit into from
May 4, 2023
Merged

Add new defaults for memory and CPU for sidecars #517

merged 1 commit into from
May 4, 2023

Conversation

burmanm
Copy link
Contributor

@burmanm burmanm commented Apr 4, 2023

What this PR does:
Modifies the default CPU and memory limits / requests for sidecars

Which issue(s) this PR fixes:
Fixes #516

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CHANGELOG.md updated (not required for documentation PRs)
  • CLA Signed: DataStax CLA

@burmanm burmanm requested a review from a team as a code owner April 4, 2023 11:51
adejanovski
adejanovski approved these changes Apr 5, 2023
View reviewed changes
Copy link
Contributor

@adejanovski adejanovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the failing tests, but the changes look good to me.
I'll let you ensure tests are ok.

@burmanm burmanm merged commit d5520d2 into k8ssandra:master May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adejanovski adejanovski adejanovski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add larger limits for sidecars
2 participants
@burmanm @adejanovski