Fix caching directories to match with newer Dockerfile, add workflow #22
Conversation
…dispatch to create a docker build with cached files
.github/workflows/release.yaml
Outdated
|
|
||
| on: | ||
| push: | ||
| tags: | ||
| - 'v*.*.*' | ||
| workflow_dispatch: | ||
| # Allow to rerun this for a tag to get updated UBI-images | ||
|
|
||
| jobs: | ||
| release_cass_operator: |
There was a problem hiding this comment.
Suggestion: Shouldn't we rename this job like you did for the workflow? something such as release_k8ssandra_client maybe?
There was a problem hiding this comment.
Yeah, I can fix that name.
| if: ${{ !env.ACT }} | ||
| uses: docker/setup-qemu-action@v2 | ||
| - name: Login to DockerHub | ||
| if: ${{ !env.ACT }} |
There was a problem hiding this comment.
Thought: interesting, that's how you create specific behaviors for ACT then 👍
Do you want to keep those for future needs in terms of local development?
There was a problem hiding this comment.
It would be nice to keep them, it helps to not require each time to have local changes to test something.
| create_the_image: | ||
| runs-on: ubuntu-latest | ||
| env: | ||
| GH_TOKEN: ${{ secrets[format('{0}', inputs.tokenSecret)] }} |
There was a problem hiding this comment.
Question: How safe is it to pass this PAT as a string input for this workflow dispatch? Any possibility that the token could leak in the logs?
There was a problem hiding this comment.
We don't pass PAT itself to this workflow. We pass a secret name (which this repository has) that has the PAT. Passing PAT itself through workflow_dispatch wouldn't be safe.
|
@burmanm, can you follow up on this? Thanks! |
…_k8ssandra_client
workflow_dispatch added to create a docker build with cached files for airgap installs
Fixes #23
Fixes #24