Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serialize long types as Strings to avoid float64 conversion in Job #411

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Serialize long types as Strings to avoid float64 conversion in Job #411

merged 1 commit into from
Oct 17, 2023

Conversation

burmanm
Copy link
Contributor

@burmanm burmanm commented Oct 16, 2023 •
edited
Loading

Fixes #412

Miles-Garnsey
Miles-Garnsey approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@Miles-Garnsey Miles-Garnsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Michael's sent me manual test results which show that the types are now set back to strings again. Approving.

@burmanm burmanm merged commit c46d8f9 into k8ssandra:master Oct 17, 2023
45 of 64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Miles-Garnsey Miles-Garnsey Miles-Garnsey approved these changes

@emerkle826 emerkle826 emerkle826 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

0.1.69 changed the serialization of JobDetails
3 participants
@burmanm @emerkle826 @Miles-Garnsey