Ensure legacy and current CRD spec version support #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ccremer
commented
Nov 26, 2020
•
ccremer
commented
- Makefile now generates CRD specs for v1 and v1beta1 (see CRD compatibility support discussion #153 )
- Structural changes in the CRD directories
- Scaffolds e2e tests for local and CI/CD runs (actual framework is left open for later)
ccremer
force-pushed
the
crd-support
branch
4 times, most recently
from
abde3dd to
cfdd349
Compare
tobru
approved these changes
Nov 26, 2020
Kidswiss
reviewed
Nov 27, 2020
ccremer
force-pushed
the
crd-support
branch
2 times, most recently
from
c95e63c to
ed8dd3c
Compare
Kidswiss
reviewed
Nov 27, 2020
|
|
Puts controller-gen into version control of go.mod and renovate instead of Makefile
New version reformats the CRDs by removing multiline-strings
So that the client uses the same API versions as the server
Updates K8s API since kustomize uses a newer version
No it's not. Can you try with latest changes? Are you on Mac or Linux? |
Neither old or new k8s would allow the v1beta1 with validation enabled. Let's see if e2e tests are working once added later.
generate now takes several seconds to complete. Running tests and starting the Operator for e2e tests wastes several seconds for stuff that doesn't change often
|
Now it's creating the CRDs in the correct folder 👍 |
Kidswiss
approved these changes
Nov 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.