Limit max concurrent jobs by type (prune, backup, check, etc.)

[susana-garcia]

Fixes #120

[susana-garcia]

I still need to refactor the constants bit with the new koanf configuration part, after that PR is merged

[ccremer]

PR #155 is now merged, you could do a rebase so that the diff is more clear :)

[susana-garcia]

@ccremer already done :)

[ccremer]

Can you add some unit tests as well? We should really start with those :)

[susana-garcia]

@ccremer I'm adding some unit tests to test the observer's methods, is that ok?

[susana-garcia]

@ccremer @Kidswiss also I forgot to ask: for the tests we want to have BDD testing? I saw that we're already using ginkgo or are you thinking on something else?

[ccremer]

@ccremer I'm adding some unit tests to test the observer's methods, is that ok?

Yes, you can limit tests for the affected change in this PR only

[ccremer]

@ccremer @Kidswiss also I forgot to ask: for the tests we want to have BDD testing? I saw that we're already using ginkgo or are you thinking on something else?

I think for this change it's sufficient to create classic unit tests with testing.T. I don't think you need the in-memory K8s API server to test the limits, unless it's very hard to mock/stub the dependent functions

[susana-garcia]

@ccremer @Kidswiss I think it's ready now, but please review it again.

[susana-garcia]

@ccremer @Kidswiss please review it again when you have a moment.

[susana-garcia]

@ccremer I think it's ready

[ccremer]

I cannot really judge whether the business logic does what is needed to. I'll let @Kidswiss judge that, but code LGTM

[susana-garcia]

@ccremer ok, thank you

[susana-garcia]

@Kidswiss I think the PR is ready