Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow default resources to be set on all job types #175

Merged
merged 2 commits into from
Dec 7, 2020
Merged

Allow default resources to be set on all job types #175

merged 2 commits into from
Dec 7, 2020

Conversation

susana-garcia
Copy link
Contributor

@susana-garcia susana-garcia commented Dec 3, 2020 •
edited
Loading

Fixes #143

@susana-garcia susana-garcia force-pushed the feat_resource_limits branch 4 times, most recently from 0ad17eb to 166b2b9 Compare December 3, 2020 11:50
@susana-garcia susana-garcia marked this pull request as ready for review December 3, 2020 11:53
Kidswiss
Kidswiss requested changes Dec 3, 2020
View reviewed changes
job/job.go Outdated Show resolved Hide resolved
job/job.go Outdated Show resolved Hide resolved
@susana-garcia susana-garcia force-pushed the feat_resource_limits branch 4 times, most recently from 4ee2679 to 5e545b9 Compare December 3, 2020 13:28
ccremer
ccremer suggested changes Dec 3, 2020
View reviewed changes
config/samples/k8up_v1alpha1_schedule.yaml Outdated Show resolved Hide resolved
cfg/config.go Outdated Show resolved Hide resolved
config/samples/k8up_v1alpha1_check.yaml Outdated Show resolved Hide resolved
api/v1alpha1/restore_types.go Outdated Show resolved Hide resolved
api/v1alpha1/restore_types.go Outdated Show resolved Hide resolved
job/job.go Outdated Show resolved Hide resolved
job/job.go Outdated Show resolved Hide resolved
job/job.go Outdated Show resolved Hide resolved
@susana-garcia susana-garcia force-pushed the feat_resource_limits branch 3 times, most recently from 7fbf885 to d7824e4 Compare December 3, 2020 15:26
@ccremer ccremer force-pushed the feat_resource_limits branch from 62af524 to d81b6a9 Compare December 4, 2020 20:51
@ccremer ccremer force-pushed the feat_resource_limits branch from d81b6a9 to 2ecac9a Compare December 4, 2020 20:57
ccremer
ccremer reviewed Dec 4, 2020
View reviewed changes
handler/schedule.go Outdated Show resolved Hide resolved
@ccremer ccremer force-pushed the feat_resource_limits branch 2 times, most recently from 41ebfa3 to 62916f9 Compare December 7, 2020 14:22
@ccremer
Allow resource requirements in specifications with global defaults
df7fa9f 
Allows to set resource requests and limits on containers of the pods with a
merging of Schedule- or global defaults
@ccremer ccremer force-pushed the feat_resource_limits branch from 62916f9 to df7fa9f Compare December 7, 2020 14:49
@ccremer ccremer changed the title add resource limits to all job types (including schedule) Allow default resources to be set on all job types Dec 7, 2020
@ccremer ccremer merged commit ef96e11 into master Dec 7, 2020
@ccremer ccremer deleted the feat_resource_limits branch December 7, 2020 14:57
@ccremer
Copy link
Contributor

ccremer commented Dec 7, 2020

Thanks @susana-garcia for the work!

@susana-garcia
Copy link
Contributor Author

@ccremer my pleasure 👍

@ccremer ccremer added the enhancement New feature or request label Dec 30, 2020
@ccremer ccremer mentioned this pull request Jan 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kidswiss Kidswiss Kidswiss requested changes

@ccremer ccremer ccremer requested changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make the backup jobs request and limits configurable
3 participants
@susana-garcia @ccremer @Kidswiss